-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shared_ptr to WS connection in API connection #119
Conversation
d08260a
to
3655fe1
Compare
When using a reference (the old code), it's possible that the referenced After changed to a shared_ptr (this PR), it's guaranteed that the |
For example, if there are 3 commands: "gethelp", "get_account" and "get_account_name", input "ge" then press TAB, the command will be completed to "get"; press TAB again, a list with all 3 commands will show; input "get_ac" then press TAB, the command will be completed to "get_account"; press TAB again, a list with "get_account" and "get_account_name" will show.
Fixed signal handling in CLI. Need troglobit/editline#29. |
d694169
to
ed3f1c8
Compare
I think this PR is ready for merge, although there are still a few issues existing in editline (e.g. troglobit/editline#26, troglobit/editline#30, troglobit/editline#31), we can bump editline later when they're fixed, but there is nothing we can do right now. By the way, OP updated. |
For bitshares/bitshares-core#1690
My opinion: don't merge this unless we've found a way to fix the side effects: bitshares/bitshares-core#1695 (comment)Update: already fixed the side effects along with some other CLI improvements, E.G.
By the way,