Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CUDA 12.2.0 to 12.2.1, fix setup support for Cuda 12.1 #703

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Bump CUDA 12.2.0 to 12.2.1, fix setup support for Cuda 12.1 #703

merged 8 commits into from
Jan 23, 2024

Conversation

Dessix
Copy link
Contributor

@Dessix Dessix commented Aug 13, 2023 •
edited
Loading

  • cuda_install.sh:
    • cuda: 12.1.0 -> 12.1.1.
    • cuda: 12.2.0 -> 12.2.1.
  • Fixes cuda_setup.py not recognizing cuda 12.1 or 12.2 in runtime selection.
  • Fixes README.md inconsistencies on 12x support.
  • Enables C++20 on NVCC 12x.
  • Integrates cleaned-up versions of several cleanup-related pull requests:

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

@github-actions github-actions bot closed this Jan 1, 2024
@TimDettmers
Copy link
Collaborator

Great addition -- thank you! Can you please address the issue and then I am happy to merge.

@TimDettmers TimDettmers reopened this Jan 1, 2024
@TimDettmers TimDettmers added medium priority (will be worked on after all high priority issues) Low Risk Risk of bugs in transformers and other libraries labels Jan 1, 2024
This was referenced Jan 1, 2024
Closed
Closed
@Dessix
Copy link
Contributor Author

Dessix commented Jan 1, 2024

@TimDettmers I believe that should do it; There are some small changes such as updating from 12.1.0 to 12.1.1 in install_cuda.py, but I believe those may be best handled in a subsequent PR in lieu of delaying this one further.

@Dessix
Copy link
Contributor Author

Dessix commented Jan 18, 2024

@TimDettmers the other PRs are now being marked as closed; can you merge this before it bitrots again?

@Titus-von-Koeller Titus-von-Koeller merged commit 3e69e8f into bitsandbytes-foundation:main Jan 23, 2024
@Titus-von-Koeller
Copy link
Collaborator

This looks good to me. Thanks for your work! We're still working hard to get on top of the maintenance load, so things were taking a while. Sorry!

Really appreciate your contribution :)

akx added a commit to akx/bitsandbytes that referenced this pull request Jan 30, 2024
@akx
CUDA setup: remove duplicate sort
5adf653 
The "sort compute capabilities" fix from bitsandbytes-foundation#703 (bitsandbytes-foundation#527) would actually do nothing due to this.
@akx akx mentioned this pull request Jan 30, 2024
Merged
Titus-von-Koeller pushed a commit that referenced this pull request Feb 4, 2024
@akx
CUDA setup cleanup (#996)
259ad44 
* Diagnostics: streamline debug printing code

* CUDA setup: Remove unused `backup_paths`

* CUDA setup: DRY OS detection

* CUDA setup: Streamline `manual_override()`

* CUDA setup: Use comment instead of string literal, simplify

* CUDA setup: remove duplicate sort

The "sort compute capabilities" fix from #703 (#527) would actually do nothing due to this.

* CUDA setup: make version number replacement logic more obvious
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Low Risk Risk of bugs in transformers and other libraries medium priority (will be worked on after all high priority issues)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dessix @TimDettmers @Titus-von-Koeller @PriNova