bugfix: change order in exception handling #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump for this getting merged. Its a small fix that should solve a reported issue |
|
anybody could help this pr? it helps resolve the problem when I have postgresql installed and the PGDATA dir is available in /etc/profiles.d, which causes the same problem. |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
|
Sorry for the slowness. This is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TimDettmers 👋🏼
It seems, in this try / except statement, that
PermissionErrorshould be aboveOSError.In fact, it just happens that
PermissionErroris an instance ofOSError, which means that any parsed paths that the user don't have access to will raise an exception and interrupt the execution 🙂The proposed change is a simple reordering of the
exceptstatements.