Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to 6.2.2 #203

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Revert to 6.2.2 #203

merged 2 commits into from
Feb 6, 2023

Conversation

vshah23
Copy link
Contributor

@vshah23 vshah23 commented Feb 6, 2023

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Users were experiencing an issue where upon checking out the merge ref for a PR the merge ref was referencing an old commit which is incorrect.

Changes

Copied the code from the version 6.2.2 release and kept the changes for GIT_CLONE_COMMIT_COMMITTER_NAME and GIT_CLONE_COMMIT_COMMITTER_EMAIL.

Investigation details

Decisions

@vshah23 vshah23 requested review from ofalvai and godrei February 6, 2023 21:49
@vshah23 vshah23 marked this pull request as ready for review February 6, 2023 22:15
@godrei godrei merged commit b1bf5cb into master Feb 6, 2023
@godrei godrei deleted the revert-to-6.2.2 branch February 6, 2023 22:19
@vincentisambart
Copy link

vincentisambart commented Feb 6, 2023

This is not a minor version change.
When migrating from 6.x to 7.x the behavior was changed so in some cases you could remove the explicit clone depth, and manual_merge was removed. With bringing back the behavior from 6.x, people who have changed their settings for 7.x now have to change them once again. And a lot of people do not check the changelog of minor version changes. Especially one with as little explanation as a cryptic "Revert to 6.2.2 by @vshah23 in #203"

@ilockett
Copy link

ilockett commented Feb 7, 2023

This is not a minor version change. When migrating from 6.x to 7.x the behavior was changed so in some cases you could remove the explicit clone depth, and manual_merge was removed. With bringing back the behavior from 6.x, people who have changed their settings for 7.x now have to change them once again. And a lot of people do not check the changelog of minor version changes. Especially one with as little explanation as a cryptic "Revert to 6.2.2 by @vshah23 in #203"

Agreed, we had clone depth set to -1 as per the previous instructions, and this has now just started failing with fatal: depth -1 is not a positive number

ofalvai added a commit that referenced this pull request Feb 13, 2023
@ofalvai ofalvai mentioned this pull request Feb 13, 2023
2 tasks
ofalvai added a commit that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants