Use PR head ref in output export #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Dec 15, 2022
| `git "fetch" "--jobs=10" "--no-tags" "--no-recurse-submodules" "origin" "refs/pr_test:refs/remotes/pr_test"`, | ||
| `git "checkout" "refs/remotes/pr_test"`, | ||
| }, | ||
| wantErrType: ParameterValidationError{}, |
There was a problem hiding this comment.
This test case is a little weird, I don't think it's valid that a build is triggered with a merge ref but without a head ref, so I changed the test to expect an error.
ofalvai
added a commit
that referenced
this pull request
Jan 3, 2023
* Use PR head ref in output export * Remove unused parameter * Fix constructor * Define head ref in E2E tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
With #186, the step checks out the PR merge ref and uses that state to export outputs, such as the commit hash and commit message. This might be confusing for users (previous discussions: #89, #165), it makes more sense to use the PR head ref for output exports.
Changes
Investigation details
Decisions