Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ATD emulator tags #35

Merged
merged 7 commits into from
May 10, 2022
Merged

Enable ATD emulator tags #35

merged 7 commits into from
May 10, 2022

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Dec 28, 2021

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a MINOR version update

Context

Enable creating ATD emulator images. More info about ATD:

https://android-developers.googleblog.com/2021/10/whats-new-in-scalable-automated-testing.html
https://developer.android.com/studio/preview/features#dolphin-testing

Changes

Adds new options to the tag step input: aosp_atd and google_atd. These are passed on to the sdkmanager call.

Investigation details

The ATD variants are not published for every CPU architecture and API version, and --channel=3 is also required to install these images. At the moment these are the valid step input combinations to install an ATD image:

avd-manager:
  inputs:
  - tag: google_atd
  - api_level: 30
  - abi: x86
  - emulator_channel: 3
avd-manager:
  inputs:
  - tag: google_atd
  - api_level: 31
  - abi: x86_64
  - emulator_channel: 3
avd-manager:
  inputs:
  - tag: google_apis
  - api_level: 32
  - abi: x86_64
  - emulator_channel: 3

Decisions

@BirmacherAkos
Copy link
Contributor

@ofalvai I'd suggest updating the description of the related step inputs.

@ofalvai ofalvai changed the title Enable aosp_atd OS tag Enable ATD emulator tags May 5, 2022
@lpusok lpusok self-requested a review May 10, 2022 08:52
step.yml Outdated Show resolved Hide resolved
shams-ahmed
shams-ahmed previously approved these changes May 10, 2022
@lpusok
Copy link
Contributor

lpusok commented May 10, 2022

Do you want to maybe add an e2e test case for a slim image?

Co-authored-by: lpusok <7979773+lpusok@users.noreply.github.com>
@ofalvai
Copy link
Contributor Author

ofalvai commented May 10, 2022

@lpusok I'm not sure, I'd rather not add a test for an unstable feature. And emulator E2E tests are already flaky enough, I think in this case the pain would be bigger than the benefit.

@ofalvai ofalvai requested a review from lpusok May 10, 2022 10:23
@ofalvai ofalvai merged commit 444ecdd into master May 10, 2022
@ofalvai ofalvai deleted the atd-os-tag branch May 10, 2022 10:47
@ofalvai ofalvai restored the atd-os-tag branch May 10, 2022 10:47
@lpusok lpusok deleted the atd-os-tag branch August 30, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants