-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ATD emulator tags #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ofalvai I'd suggest updating the description of the related step inputs. |
lpusok
reviewed
May 10, 2022
shams-ahmed
previously approved these changes
May 10, 2022
Do you want to maybe add an e2e test case for a slim image? |
Co-authored-by: lpusok <7979773+lpusok@users.noreply.github.com>
@lpusok I'm not sure, I'd rather not add a test for an unstable feature. And emulator E2E tests are already flaky enough, I think in this case the pain would be bigger than the benefit. |
lpusok
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.yml
andREADME.md
is updated with the changes (if needed)Version
Requires a MINOR version update
Context
Enable creating ATD emulator images. More info about ATD:
https://android-developers.googleblog.com/2021/10/whats-new-in-scalable-automated-testing.html
https://developer.android.com/studio/preview/features#dolphin-testing
Changes
Adds new options to the
tag
step input:aosp_atd
andgoogle_atd
. These are passed on to thesdkmanager
call.Investigation details
The ATD variants are not published for every CPU architecture and API version, and
--channel=3
is also required to install these images. At the moment these are the valid step input combinations to install an ATD image:Decisions