Refactor step structure #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
reviewed
Aug 18, 2021
| if err != nil { | ||
| return Config{}, nil | ||
| } | ||
| stepconf.Print(input) |
There was a problem hiding this comment.
we had this TODO in activate-ssh-key: TODO: log.Infof(stepconf.toString(input)), we could solve it with this PR
|
I would consider the refactoring done if we can write unit tests like:
|
godrei
reviewed
Aug 19, 2021
godrei
reviewed
Aug 19, 2021
Bence1001
reviewed
Aug 23, 2021
godrei
previously approved these changes
Aug 24, 2021
godrei
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Context
Refactoring step structure, updating
go-utilsand handling its breaking changes.Changes
apk_path_pattern. This was marked to be removed on 20 August 2019. ¯_(ツ)_/¯main.gotostep.goInvestigation details
Decisions