Refactor E2E tests, generate readme #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
requested changes
Aug 17, 2021
e2e/bitrise.yml
Outdated
| if [ -z "$BITRISE_AAB_PATH" ] ; then echo "BITRISE_AAB_PATH env is empty" ; exit 1 ; fi ; | ||
| if [ -z "$BITRISE_AAB_PATH_LIST" ] ; then echo "BITRISE_AAB_PATH_LIST env is empty" ; exit 1 ; fi ; | ||
|
|
||
| if [ ! -f $BITRISE_DEPLOY_DIR/$EXPECTED_AAB ] ; then |
There was a problem hiding this comment.
Suggested change
| if [ ! -f $BITRISE_DEPLOY_DIR/$EXPECTED_AAB ] ; then | |
| if [ ! -f "$BITRISE_DEPLOY_DIR/$EXPECTED_AAB" ] ; then |
To prevent unexpected false positives with empty strings (right now i can not be empty tough).
e2e/bitrise.yml
Outdated
| test_nested_module: | ||
| title: Test simple Android project with nested module | ||
| envs: | ||
| - SAMPLE_APP_URL: https://github.com/bitrise-io/android-multiple-test-results-sample.git |
There was a problem hiding this comment.
Suggested change
| - SAMPLE_APP_URL: https://github.com/bitrise-io/android-multiple-test-results-sample.git | |
| - TEST_APP_URL: https://github.com/bitrise-io/android-multiple-test-results-sample.git |
As used for example in https://github.com/bitrise-steplib/steps-xcode-test/blob/5de2593fa7291ff3e6bf25b54f061da7ee823713/e2e/bitrise.yml.
There was a problem hiding this comment.
Thank you, fixed. (I didn't accept this suggestion because there are more instances of this env var in the file)
lpusok
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Context
Part of the initiative to refactor step to new standards.
Changes
README.mdwith generator stepe2e/bitrise.yml/tmpdir but otherwise test the same thingsInvestigation details
Decisions