Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging skipped by pr description #117

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

vturda
Copy link
Contributor

@vturda vturda commented Jul 15, 2022

New Pull Request Checklist

  • Run go fmt on your files (e.g. go fmt ./service/common.go, or on the whole service folder: go fmt ./service/...)
  • Write tests for your code
    • The tests should cover both "success" and "error" cases.
    • The tests should also check all the returned variables, don't ignore any returned value!
    • Ideally the tests should be easily readable, we usually use tests to document our code instead of code comments.
      An example, if you'd write a comment like "Given X this function will return Y" or
      "Beware, if the input is X this function will return Y" then you should implement this as
      a unit test, instead of writing it as a comment.
  • If your Pull Request is more than a bug fix you should also check README.md and change/add the descriptions there - also
    feel free to add yourself as a contributor if you implement support for a new service ;)
  • Before creating the Pull Request you should also run bitrise run test with the Bitrise CLI,
    to perform all the automatic checks (which will run on your Pull Request when you open it).

Summary of Pull Request

Logging how many users use ci skip in pull request and merge request descriptions.

@vturda vturda requested a review from sylank July 15, 2022 11:42
Copy link

@sylank sylank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   🎩 
👌 👀  👍 
   👄 
   |
  / \

@vturda vturda merged commit 21c3cbc into master Jul 15, 2022
@vturda vturda deleted the logging-skipped-by-pr-description branch July 15, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants