Make it easier to update gradle verification reference #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e991fb9 to
3b9e268
Compare
bitrise.yml
Outdated
| test: | ||
| after_run: |
There was a problem hiding this comment.
Since check_gradle_verification contains only bundle::generate_gradle_verification_reference: { }, and that is also explicitly added here, it will be run twice. Why do we need this after_run?
There was a problem hiding this comment.
The idea was to check if it is up-to-date even when running the test WF locally.
bitrise.yml
Outdated
| - bundle::generate_gradle_verification_reference: { } | ||
|
|
||
| step_bundles: | ||
| generate_gradle_verification_reference: |
There was a problem hiding this comment.
Since this also performs a check I'd call this check_gradle_verification_reference
zsolt-marta-bitrise
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_gradle_verification) that can be used to update verification-metadata.xml.This is now included when running tests, to make sure it is kept up-to-date.