Skip to content

Commit

Permalink
Merge pull request #64 from bitrise-io/fix-error-log
Browse files Browse the repository at this point in the history
fix: Return error if xcode commands fail
  • Loading branch information
zsolt-marta-bitrise authored Nov 25, 2024
2 parents ee5eb84 + 40639bb commit 9dba0fa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cmd/restoreXcodeDerivedDataFiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ var restoreXcodeDerivedDataFilesCmd = &cobra.Command{
}
}

tracker.LogRestoreFinished(time.Since(startT), err)
tracker.LogRestoreFinished(time.Since(startT), cmdError)
if cmdError != nil {
return fmt.Errorf("restore Xcode DerivedData from Bitrise Build Cache: %w", cmdError)
}
Expand Down
6 changes: 3 additions & 3 deletions cmd/saveXcodeDerivedDataFiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ var saveXcodeDerivedDataFilesCmd = &cobra.Command{
}
}

tracker.LogSaveFinished(time.Since(startT), err)
if err != nil {
return fmt.Errorf("save Xcode cache into Bitrise Build Cache: %w", err)
tracker.LogSaveFinished(time.Since(startT), cmdError)
if cmdError != nil {
return fmt.Errorf("save Xcode cache into Bitrise Build Cache: %w", cmdError)
}

logger.TInfof("✅ Cache directories saved into Bitrise Build Cache ")
Expand Down

0 comments on commit 9dba0fa

Please sign in to comment.