Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/containers] Fix comments workflow to manage any comment from users #33011

Merged
merged 1 commit into from
May 8, 2023

Conversation

fmulero
Copy link
Collaborator

@fmulero fmulero commented May 8, 2023

Description of the change

Amend conditions in comments.yaml workflow to manage any comment from users.

The order in the conditions were also changed to be more readable.

Benefits

Comments on issues or pull request without any label were being ignored. This problem was affecting mainly to issues created before these workflows were deployed.

Possible drawbacks

None identified

Applicable issues

Example of issue not managed properly by the workflow

More information

bitnami/charts#16426

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero fmulero changed the title [bitnami/charts] Fix comments workflow to manage any comment from users [bitnami/containers] Fix comments workflow to manage any comment from users May 8, 2023
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label May 8, 2023
@bitnami-bot bitnami-bot requested a review from gongomgra May 8, 2023 08:18
@fmulero fmulero merged commit 8d92f61 into bitnami:main May 8, 2023
@fmulero fmulero deleted the bugfix/comments-on-closed-issues branch May 8, 2023 08:29
@github-actions github-actions bot added the solved label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants