Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multi-arch docker images #367

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Implement multi-arch docker images #367

merged 1 commit into from
Mar 2, 2020

Conversation

mkmik
Copy link
Collaborator

@mkmik mkmik commented Feb 28, 2020

not a fan of all this Makefile complexity, but I don't want to shave this yak now.

(in another PR I want to put all the intermediate target files in a build/ directory so it can be more easily cleaned and .gitignored)

Closes #349

Copy link

@atomatt atomatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. it looks ok but I don't pretend to follow everything that's going on.

@mkmik mkmik force-pushed the multiarch branch 8 times, most recently from 78901ac to 422fea1 Compare March 2, 2020 11:03
@mkmik
Copy link
Collaborator Author

mkmik commented Mar 2, 2020

bors r+

bors bot added a commit that referenced this pull request Mar 2, 2020
367: Implement multi-arch docker images r=mkmik a=mkmik

not a fan of all this Makefile complexity, but I don't want to shave this yak now.

(in another PR I want to put all the intermediate target files in a `build/` directory so it can be more easily cleaned and .gitignored)

Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
@bors
Copy link
Contributor

bors bot commented Mar 2, 2020

Build failed

@mkmik
Copy link
Collaborator Author

mkmik commented Mar 2, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 2, 2020

Build succeeded

@bors bors bot merged commit f9e477c into master Mar 2, 2020
@bors bors bot deleted the multiarch branch March 2, 2020 13:05
@mkmik mkmik mentioned this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide multi-arch Container image for sealed secrets controller
2 participants