Add SealedSecret 'template' to use when constructing Secret #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcf547d to
68631a2
Compare
This change adds a `spec.template` to the SealedSecrets schema, which includes `metadata` and `type` used when constructing the new Secret. (All the Secret fields _other_ than `data`/`encryptedData`) Also this change adds: - Events to the SealedSecret describing progress/errors while unsealing. - A SealedSecret `status` structure that exposes overall success/failure. Fixes #92 Fixes #72
This was referenced Jul 10, 2019
|
bors r+ |
|
👎 Rejected by too few approved reviews |
|
bors r+ based on a very superficial review 🤞 |
|
🔒 Permission denied Existing reviewers: click here to make atomatt a reviewer |
|
bors delegate=atomatt |
|
✌️ atomatt can now approve this pull request |
atomatt
approved these changes
Jul 10, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 10, 2019
180: Add SealedSecret 'template' to use when constructing Secret r=atomatt a=mkmik Merge #129 into current codebase (which as diverged in the meantime) ``` This change adds a spec.template to the SealedSecrets schema, which includes metadata and type used when constructing the new Secret. (All the Secret fields other than data/encryptedData) Also this change adds: Events to the SealedSecret describing progress/errors while unsealing. A SealedSecret status structure that exposes overall success/failure. ``` Fixes #92 Fixes #72 Co-authored-by: Angus Lees <gus@inodes.org> Co-authored-by: Marko Mikulicic <mkm@bitnami.com> Co-authored-by: Christopher Harm <crh5255@psu.edu>
Build succeeded |
|
Could be labelled as 0.8.0 as well :) |
To avoid overcrowding the milestone "changelog" I tended to favour labelling tracking issues (such as #92 in this case) over PRs. My mind can easily be changed with arguments :-) |
|
@mkmik I had the opposite practice as it allows to track which work get into which milestone, after several years I found it useful. But your point is just as fine it just address different concerns ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #129 into current codebase (which as diverged in the meantime)
Fixes #92
Fixes #72