Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dashboard configmap annotations #1302

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add dashboard configmap annotations #1302

merged 1 commit into from
Aug 23, 2023

Conversation

alemorcuq
Copy link
Collaborator

Description of the change
Add annotations to the Grafana Dashboards ConfigMap via metrics.dashboards.annotations.

Applicable issues

@alemorcuq
Add dashboard configmap annotations
0d139b2 
Signed-off-by: Alejandro Moreno <amorenoc@vmware.com>
@alemorcuq alemorcuq force-pushed the 1290-dashboard-annotations branch from 2882b7c to 0d139b2 Compare August 23, 2023 07:08
alvneiayu
alvneiayu approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alemorcuq alemorcuq merged commit 93bb401 into bitnami-labs:main Aug 23, 2023
@alemorcuq alemorcuq deleted the 1290-dashboard-annotations branch August 23, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvneiayu alvneiayu alvneiayu approved these changes

@agarcia-oss agarcia-oss Awaiting requested review from agarcia-oss agarcia-oss is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to add annotations to grafana dashboard in helm chart.
2 participants
@alemorcuq @alvneiayu