Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure approved runs vib #1121

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Ensure approved runs vib #1121

merged 1 commit into from
Mar 6, 2023

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Mar 2, 2023

Description of the change

Add check to ensure VIB validations only happen on approved PRs.

@josvazg josvazg self-assigned this Mar 2, 2023
@josvazg josvazg force-pushed the ensure-approved-runs-vib branch 3 times, most recently from 3ab2c8b to fdada2c Compare March 2, 2023 17:40
alvneiayu
alvneiayu previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agarcia-oss
agarcia-oss previously approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@agarcia-oss agarcia-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josvazg josvazg dismissed stale reviews from agarcia-oss and alvneiayu via 4c934a3 March 6, 2023 12:25
@josvazg josvazg force-pushed the ensure-approved-runs-vib branch 3 times, most recently from a3b48a0 to ff4c4e0 Compare March 6, 2023 13:43
Ensure vib runs only when PR is approved
d14ffcc 
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
@josvazg josvazg force-pushed the ensure-approved-runs-vib branch from ff4c4e0 to d14ffcc Compare March 6, 2023 14:21
alvneiayu
alvneiayu approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josvazg josvazg merged commit f57c77d into bitnami-labs:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvneiayu alvneiayu alvneiayu approved these changes

@agarcia-oss agarcia-oss agarcia-oss left review comments

@alemorcuq alemorcuq Awaiting requested review from alemorcuq

Assignees

@josvazg josvazg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josvazg @agarcia-oss @alvneiayu