Allow to disable secret auto-recreation #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07a963b to
37ae31f
Compare
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
37ae31f to
ac73912
Compare
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
f2d971f to
b866e6a
Compare
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
f54fd26 to
5325e94
Compare
alemorcuq
suggested changes
Mar 3, 2023
josvazg
commented
Mar 6, 2023
josvazg
commented
Mar 6, 2023
Co-authored-by: Alejandro Moreno <amorenoc@vmware.com> Signed-off-by: josvaz <josvaz@vmware.com>
$ helm template helm/sealed-secrets/ --set skipRecreate=true |grep args -A 5
args:
- --update-status
- --skip-recreate
- --key-prefix
- "sealed-secrets-key"
image: docker.io/bitnami/sealed-secrets-controller:v0.19.5 |
alemorcuq
suggested changes
Mar 6, 2023
f1958dc to
d73a487
Compare
Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
d73a487 to
3cebdeb
Compare
alemorcuq
suggested changes
Mar 6, 2023
Co-authored-by: Alejandro Moreno <amorenoc@vmware.com> Signed-off-by: josvaz <josvaz@vmware.com> Signed-off-by: Jose Luis Vazquez Gonzalez <josvaz@vmware.com>
24788dd to
1e03569
Compare
alemorcuq
approved these changes
Mar 6, 2023
| @@ -56,6 +56,12 @@ secretName: "sealed-secrets-key" | |||
| ## @param updateStatus Specifies whether the Sealed Secrets controller should update the status subresource | |||
| ## | |||
| updateStatus: true | |||
| ## @param skipRecreate Specifies whether the Sealed Secrets controller should skip recreating removed secrets | |||
| ## Setting it to false allows to optionally restore backward compatibility in low priviledge | |||
There was a problem hiding this comment.
Just noticed this small typo ^^
This message is talking about the case in which skipRecreate is actually set to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add a new recreate flag, on by default, that when switched off allows to opt in for lost backward compatibility after the introduction of automatic secret recreation by PR #963.
Benefits
Some low privilege environment do not allow users to watch secrets, so this will allow them to still install sealed secrets just by using the new recreate flag set to
false.Possible drawbacks
It is still a manual fix, as we want it to be a explicit opt in. Also the error about lack of permissions for watching secrets will not point you to this flag. But still this flag should help as it skips secrets watching completely.
Applicable issues
Additional information
Reported at #1064