Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build multiarch docker images for AMD64, ARM64 and ARMv7l architectures #360

Closed
xunholy opened this issue Feb 22, 2020 · 4 comments
Closed

Build multiarch docker images for AMD64, ARM64 and ARMv7l architectures #360

xunholy opened this issue Feb 22, 2020 · 4 comments
Milestone
v0.10.0

Comments

@xunholy
Copy link

xunholy commented Feb 22, 2020

Given my architecture type is armv7l, and Kubernetes is compatible with armv7l architecture I would like to be able to compile sealed secrets for this format.

Ideally, either --build-args could be used or alternatively docker buildx to compile across platform architecture.

sealed-secrets/Makefile

Line 60 in b50dbfb

$(DOCKER) build -t $(CONTROLLER_IMAGE) docker/

@mkmik
Copy link
Collaborator

mkmik commented Feb 22, 2020

IIRC we don't build the binary as part of the docker image but we only copy it inside the image. Anyway it's trivial to cross-conpile go

@xunholy
Copy link
Author

xunholy commented Feb 22, 2020

@mkmik correct, seeing that is is trivial, any foresight into when you might compile for the armv7l platform architecture?

@mkmik
Copy link
Collaborator

mkmik commented Feb 23, 2020

Yes.

@mkmik mkmik added this to the v0.10.0 milestone Feb 25, 2020
@mkmik mkmik changed the title Support compiling ARMv7l Architecture Build multiarch docker images for AMD64, ARM64 and ARMv7l architectures Feb 25, 2020
mkmik pushed a commit that referenced this issue Feb 25, 2020
Use static distroless flavour
dcd568d 
This is the first step towards settup up a multi-arch image (see #360).

We don't need real base images, we can use one single distroless base image
for all architectures, since the only arch specific thing is the binary we cross-build
outside of docker anyway.

The actual multi-arch build will be added in another PR.

I tested this change manually in a test cluster.
@mkmik mkmik mentioned this issue Feb 25, 2020
Merged
@mkmik
Copy link
Collaborator

mkmik commented Mar 2, 2020

Duplicate of #349

@mkmik mkmik marked this as a duplicate of #349 Mar 2, 2020
@mkmik mkmik closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@mkmik @xunholy