Add multiview demo #124
Merged
Add multiview demo #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitmovin-kenny
requested changes
Mar 7, 2025
Comment on lines
+199
to
+202
| if (newPrimaryPlayer == null) { | ||
| primarySource = null; | ||
| return; | ||
| } |
There was a problem hiding this comment.
you already checked for null at the start of the function
There was a problem hiding this comment.
nice catch! Actually I needed to keep this one and remove the one at the start, otherwise we'll run into an exception when the last source gets disabled.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a demo for Multiview playback, using multiple players that can be toggled dynamically.
It uses multiple players and UI instances, with the UI control bars getting moved, resized, and selectively hidden to make it seem like there is one common control bar.
Drag-and-drop can be used to rearrange currently active sources.
There is always one "primary" player - it is the one that is controlled through the timeline, and playing audio. All other players are muted. Switching the primary player is done by clicking on another player. It will then take over the audio volume settings from the previous primary player.