This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Enabling multiple oauth2_proxy's to exist on the same domain #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,7 +302,7 @@ func (p *OauthProxy) SignInPage(rw http.ResponseWriter, req *http.Request, code | |||
| rw.WriteHeader(code) | |||
|
|
|||
| redirect_url := req.URL.RequestURI() | |||
| if redirect_url == signInPath { | |||
| if redirect_url == fmt.Sprintf(signInPathFormat, p.ProxyPrefix) { | |||
There was a problem hiding this comment.
Can you move these string formatting blocks to happen once when the &OauthProxy{...} is created? You can also drop the const's.
|
@tonymeng some comments on implementation, but this change in general sounds like it adds a bit of flexibility which is nice. |
| @@ -131,7 +132,7 @@ func NewOauthProxy(opts *Options, validator func(string) bool) *OauthProxy { | |||
| } | |||
|
|
|||
| return &OauthProxy{ | |||
| CookieKey: "_oauthproxy", | |||
| CookieKey: fmt.Sprintf("_oauthproxy_%s", opts.ProxyPrefix), | |||
There was a problem hiding this comment.
Let's just make CookieKey a separate configurable not tied to ProxyPrefix
|
@jehiah thanks for getting back to me so fast, i've updated it per your comments, back to you :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables multiple oauth2_proxy's to operate on the same domain while enforcing different levels of security.
The changes required involve namespacing the web template for the specific oauth2_proxy hosting it and namespacing the cookie's key.