Improve get-position to properly handle block comments and multi-line braces #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a pull request that should resolve #14 as well as #10. It also detects flow type
import type
definitions, and places other imports above those (so the order is external imports -> local imports -> type imports)To do this it adds a few methods to
get-position
:isComment
,isTypeDefinition
andisInBracketOrComment
.There's some added complexity in the main
get-position
function to track the context that the current line is part of (if it is within a block comment or a bracket), plus some additional logic to handle those conditions.I think I've handled most of the edge cases but please test and let me know if it needs any further improvements!