Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No results" missing if ngx-mat-select-search wrapped in <mat-option> #101

Closed
mstawick opened this issue Jan 23, 2019 · 2 comments · Fixed by #102
Closed

"No results" missing if ngx-mat-select-search wrapped in <mat-option> #101

mstawick opened this issue Jan 23, 2019 · 2 comments · Fixed by #102
Labels
bug Something isn't working

Comments

@mstawick
Copy link
Contributor

If ngx-mat-select-search is wrapped in <mat-option>, the "No results" label will not show. It looks like it's just cut-off.

This can be seen in stackblitz examples. The Single selection example is broken, since it's wrapped, and the Multiple selection works fine, since it's not.

Thanks for this great component.
macjohnny added a commit that referenced this issue Jan 23, 2019
@macjohnny
#101: show no entries found when inside mat-option
474279b
macjohnny added a commit that referenced this issue Jan 24, 2019
@macjohnny
#101: show no entries found and fix styling when inside mat-option
bf23a03
@macjohnny macjohnny added the bug Something isn't working label Jan 24, 2019
@macjohnny
Copy link
Member

@mstawick thanks a lot for reporting this issue. I am about to release a fixed version.

@macjohnny macjohnny mentioned this issue Jan 24, 2019
Merged
@macjohnny
Copy link
Member

the fix was release in 1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix "no entries found" not shown inside when mat-option bithost-gmbh/ngx-mat-select-search
2 participants
@mstawick @macjohnny