-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction tax report #373
Closed
ZIMkaRU
wants to merge
88
commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-transaction-tax-report
Closed
Add transaction tax report #373
ZIMkaRU
wants to merge
88
commits into
bitfinexcom:staging
from
ZIMkaRU:feature/add-transaction-tax-report
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZIMkaRU
force-pushed
the
feature/add-transaction-tax-report
branch
from
May 6, 2024 11:05
0e5be86
to
43e2756
Compare
2 tasks
This was referenced May 21, 2024
This was referenced Jun 20, 2024
done in small separated PRs |
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Transaction Tax Report
Adds two strategies to calculate the user's trades
FIFO
andLIFO
.FIFO
(first-in-first-out) andLIFO
(last-in-first-out) are two accounting methods used to calculate cryptocurrency gains and losses, see this articleFor conversion currencies are used the
Public Trades
endpoint of theBFX
api_v2: https://docs.bitfinex.com/reference/rest-public-tradesBasic changes:
getTransactionTaxReport
endpointgetTransactionTaxReportFile
endpointmakeTrxTaxReportInBackground
endpointgetTransactionTaxReport
request examplegetTransactionTaxReport
response examplegetTransactionTaxReportFile
request examplegetTransactionTaxReportFile
response examplemakeTrxTaxReportInBackground
request examplemakeTrxTaxReportInBackground
response exampleThe idea of the
makeTrxTaxReportInBackground
endpoint is the following:the big users may have a lot of trades for a certain year
to convert currencies to USD are used the public trades endpoint of the BFX API with 15reqs/min rate limit
it can lead to significant time in report generation
to fight HTTP timeout for this case, it is necessary to send
makeTrxTaxReportInBackground
HTTP request to schedule generationand when the report generation is successful the data of the tax report will be responded via WebSocket
emitTrxTaxReportGenerationInBackgroundToOne
WS event example:emitTrxTaxReportGenerationInBackgroundToOne
WS event example in case anerror
Depends on this PR: