Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvements) Columns width adjustments #805

Merged
merged 32 commits into from
Apr 15, 2024
Merged

(improvements) Columns width adjustments #805

merged 32 commits into from
Apr 15, 2024

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Apr 12, 2024 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1207006561310219/f

Description:

  • Implements the possibility of manually adjusting columns width and persisting these between sessions
  • Adds the ability to set the auto-calculated dynamic defaults via the context menu
  • Refactors and optimizes DataTable component
  • Improves charts responsiveness

Preview:

cols-adjustments-prev.mov

Depends on:

prdn and others added 30 commits April 3, 2024 09:58
@prdn
Merge pull request bitfinexcom#799 from bitfinexcom/staging
d825d44 
Release version to master
@prdn
Merge pull request bitfinexcom#802 from bitfinexcom/staging
d4a4321 
Update reversion in tables width
@alexstotsky
Revert "Revert "(improvements) Tables responsiveness""
8f66735 
This reverts commit 2370321.
@alexstotsky
Implement onColumnWidthChanged handler
f8ab01b
@alexstotsky
Fix setColumnsWidth action payload handling
a3e90a1
@alexstotsky
Update calculated widths with chnaged values
bf78086
@alexstotsky
Update default widths with calculted ones
48f60d6
@alexstotsky
Adjust min columns width
d1e8d15
@alexstotsky
Lint fix
909db4a
@alexstotsky
Improve calculated withs handling, update constants
0c00466
@alexstotsky
Implement custom width handling flow
ee4baeb
@alexstotsky
Add customCols width getter
47c3065
@alexstotsky
Fix setColumnsWidth action payload providing
b16a84e
@alexstotsky
Implement customColsWidths availability check
d7067bb
@alexstotsky
Add cols width getter default
26470cd
@alexstotsky
Implement custom cols widths reset flow
24ef9ea
@alexstotsky
Actualized keys&descriptions
779b2bf
@alexstotsky
Update reset to defaults label
7dc569b
@alexstotsky
Cleanup
a25695f
@alexstotsky
Update query constants
71ded58
@alexstotsky
Provide summary by asset query type
1033afd
@alexstotsky
Actualize columns constants
83b338c
@alexstotsky
Update app summary cols getters
de17e4a
@alexstotsky
Actualize summary by asset cols config
510e841
@alexstotsky
Make columns resizing adjustable
12bb2f7
@alexstotsky
Prevent resising for small acc summary sections
47fbcd9
@alexstotsky
Show reset cols width only for resizable ones
e749a27
@alexstotsky
Actualize wallets tables configs
631dd15
@alexstotsky
Improve concentration risk data table configuration
b3f1a8f
@alexstotsky
Enhance cilumns widthchnaging flow
20f789a
@alexstotsky alexstotsky changed the title [WIP] (improvements) Columns width adjustments (improvements) Columns width adjustments Apr 12, 2024
@alexstotsky alexstotsky marked this pull request as ready for review April 12, 2024 09:47
ezewer
ezewer approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 2281a85 into bitfinexcom:staging Apr 15, 2024
@alexstotsky alexstotsky deleted the cols-adjust branch April 16, 2024 09:22
This was referenced Apr 17, 2024
Merged
Merged
@alexstotsky alexstotsky mentioned this pull request Apr 18, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi elvis-poggi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn