Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvements) Sync state checking flow #735

Merged
merged 6 commits into from
Nov 28, 2023
Merged

(improvements) Sync state checking flow #735

merged 6 commits into from
Nov 28, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Nov 24, 2023 •
edited
Loading

Task: https://app.asana.com/0/1163495710802945/1205941559124263/f

Description:

  • Improves synchronization state checking flow and fixes a couple of potential issues that have been spotted in some syncing scenarios

@alexstotsky alexstotsky changed the title [WIP] (improvements) Sync state checking flow (improvements) Sync state checking flow Nov 24, 2023
@alexstotsky alexstotsky marked this pull request as ready for review November 24, 2023 11:03
ezewer
ezewer approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ezewer ezewer merged commit 362f9b8 into bitfinexcom:staging Nov 28, 2023
@alexstotsky alexstotsky deleted the improve-sync-end-checking branch November 28, 2023 13:37
This was referenced Nov 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi Awaiting requested review from elvis-poggi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi