Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(improvement) Hide unrealized profit selectors #730

Merged
merged 3 commits into from
Nov 24, 2023
Merged

(improvement) Hide unrealized profit selectors #730

merged 3 commits into from
Nov 24, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Nov 14, 2023 •
edited
Loading

Task: https://bitfinex.slack.com/archives/C024AMXFVPD/p1699977613046249?thread_ts=1699973411.324929&cid=C024AMXFVPD

Description:

  • Temporarily hides Unrealized Profit selectors from the new app Summary and Account Balance reports according to this proposal

Preview:

Screenshot 2023-11-14 at 18 37 53

@alexstotsky alexstotsky changed the base branch from master to staging November 14, 2023 16:37
@alexstotsky alexstotsky marked this pull request as ready for review November 14, 2023 16:44
ezewer
ezewer approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spoke with vlad we would hide this for the time being.

@ezewer ezewer merged commit 2876a38 into bitfinexcom:staging Nov 24, 2023
@alexstotsky alexstotsky deleted the hide-unrealized-profit-selectors branch November 24, 2023 11:50
@alexstotsky alexstotsky mentioned this pull request Nov 27, 2023
Merged
1 task
This was referenced Nov 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi elvis-poggi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstotsky @ezewer @elvis-poggi