Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) New Summary: summary by asset section #726

Merged
merged 114 commits into from
Nov 14, 2023
Merged

(feature) New Summary: summary by asset section #726

merged 114 commits into from
Nov 14, 2023

Conversation

alexstotsky
Copy link
Contributor

@alexstotsky alexstotsky commented Nov 9, 2023 •
edited
Loading

Tasks:
https://app.asana.com/0/1163495710802945/1204776097979485/f
https://app.asana.com/0/1163495710802945/1205133325932386
https://app.asana.com/0/1163495710802945/1205924412881197

Description:

  • Implements Summary by Asset section for the last 30 days on the new Summary for the Reports app
  • Adds refreshing for all Summary sections on the Filter button click

Preview:

summary_by_asset_pev

all-sections-refresh.mov

Depends on:

prdn and others added 30 commits October 31, 2023 08:24
@prdn
Merge pull request bitfinexcom#725 from bitfinexcom/staging
a11ddc2 
Release version to master
Add summary by asset keys/descriptions
19eb420
[wip]App summary by asset section
0ff56ec
Add summary by asset range clarification
bed0951
Actualize section titles
a31ec97
Add byAsset section to the app summary
8487876
Make data rows default height configurable
95854da
Update summary by asset item classNames
e9c7d81
Adjust full screen sub-sections styling
eb71a47
Add summary by asset cols keys/descriptions
2cebfd4
Add summary by asset constants
199b9f9
Implement summary by asset actions
ba474e2
[wip]Summary by asset reducers
e26468d
Actualize framework mode reducers config
4537db7
Add summary by asset selectors
fc432ce
[wip]Implement summary by asset sagas
db8f443
Update root saga configuration
baf86c8
Add asset initial data
315c365
Implement getSummaryByAssetEntries and getSummaryByAssetTotal selectors
6a3cf35
Implement summary by asset data preparing helper
966d322
Update keys/descriptions
17a5a99
Imporve summary data formatter
aa9be17
Add summary by asset helpers
da70191
Optimize translation handler usage, cleanup
6ebf551
Implement app summary columns getters
385dfc6
Optimize account fees section, cleanup
64b0369
Actualize summary by asset columns titles
3bfb716
Update columns getter ids
9087a13
Fix tooltip overflowing issue
926ec0d
[wip] Summary by asset col getter
b719259
@alexstotsky alexstotsky marked this pull request as ready for review November 9, 2023 11:50
ezewer
ezewer approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ezewer ezewer merged commit 835d280 into bitfinexcom:staging Nov 14, 2023
@alexstotsky alexstotsky deleted the summary-by-asset branch November 14, 2023 10:31
This was referenced Nov 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezewer ezewer ezewer approved these changes

@elvis-poggi elvis-poggi Awaiting requested review from elvis-poggi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexstotsky @ezewer @elvis-poggi @prdn