Merge pull request #2110 from gomezdn/fix/improve-error-message-when-…

…signing-tx-with-no-outputs fix: added error with clear message when signing a tx without outputs
bitcoinjs · Jun 15, 2024 · c6105c4 · c6105c4
2 parents d54a0d0 + 4802803
commit c6105c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/transaction.js b/src/transaction.js
@@ -318,6 +318,8 @@ class Transaction {
       hashSequences = bcrypto.sha256(bufferWriter.end());
     }
     if (!(isNone || isSingle)) {
+      if (!this.outs.length)
+        throw new Error('Add outputs to the transaction before signing.');
       const txOutsSize = this.outs
         .map(output => 8 + varSliceSize(output.script))
         .reduce((a, b) => a + b);

diff --git a/ts_src/transaction.ts b/ts_src/transaction.ts
@@ -414,6 +414,8 @@ export class Transaction {
     }
 
     if (!(isNone || isSingle)) {
+      if (!this.outs.length)
+        throw new Error('Add outputs to the transaction before signing.');
       const txOutsSize = this.outs
         .map(output => 8 + varSliceSize(output.script))
         .reduce((a, b) => a + b);