Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin idna_adapter dep to fix reqest with MSRV 1.75 #1859

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Feb 27, 2025

Description

The bdk_esplora crate depends on reqwest which now pins it's idna_adapter version to support newer versions of the url crate when testing with it's MSRV. I fixed our CI 1.75 MSRV build by also pinning the idna_adapter.

Notes to the reviewers

The MSRV break was fixed by the reqwest team with seanmonstar/reqwest#2470.

This change was made 2 mo ago, I'm not sure why our CI only broke now.

Changelog notice

  • Pin idna_adapter dep to fix reqwest with MSRV 1.75.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Feb 27, 2025
@notmandatory notmandatory added this to the 1.2.0 milestone Feb 27, 2025
@notmandatory notmandatory marked this pull request as ready for review February 27, 2025 02:27
@notmandatory notmandatory marked this pull request as draft February 27, 2025 02:32
@notmandatory
Copy link
Member Author

I moved this back to DRAFT, I may have found a smaller change to fix this.

@notmandatory notmandatory changed the title ci: change MSRV for bdk_esplora to 1.75 and pin broken deps ci: pin idna_adapter dep to fix reqest with MSRV 1.75 Feb 27, 2025
@notmandatory notmandatory marked this pull request as ready for review February 27, 2025 03:01
@notmandatory
Copy link
Member Author

Ready to review/merge.

Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d4670b3

@evanlinjin evanlinjin merged commit 46c218a into bitcoindevkit:master Feb 27, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants