Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline the NDK version used in Android build and CI #242

Closed
thunderbiscuit opened this issue Aug 17, 2022 · 2 comments · Fixed by #414
Closed

Streamline the NDK version used in Android build and CI #242

thunderbiscuit opened this issue Aug 17, 2022 · 2 comments · Fixed by #414
Assignees
@thunderbiscuit
Labels
CI Continuous integration pipeline related language: kotlin platform: android

Comments

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Aug 17, 2022 •
edited
Loading

When using the ubuntu-latest (ubuntu-20.04), the CI has also migrated to NDK version 25 (see issue here).

We should try to use a more recent version of NDK.
@thunderbiscuit thunderbiscuit transferred this issue from bitcoindevkit/bdk-kotlin Nov 15, 2022
@notmandatory notmandatory added language: kotlin platform: android CI Continuous integration pipeline related labels Nov 17, 2022
@thunderbiscuit
Copy link
Member Author

Updating to the latest NDK is a long-standing issue with uniffi-rs and Rust in general. Here are some links to keep track of some of the conversation and progress around this:

  1. Android NDK 25 [firefox-android: main] mozilla/application-services#5442
  2. Update Android NDK to 25 mozilla/application-services#5436
  3. 94.3.0 release has a linkage problem in some devices mozilla/application-services#5165
  4. note: ld: error: unable to find library -lgcc mozilla/rust-android-gradle#75
  5. Support Android ndk versions r23-beta3 and up rust-lang/rust#85806
  6. Update CI to use Android NDK r25b rust-lang/rust#102332

@thunderbiscuit thunderbiscuit self-assigned this Mar 30, 2023
This was referenced Mar 30, 2023
Merged
Merged
@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Apr 5, 2023 •
edited
Loading

Currently updating to the latest NDK works only for some builds:

The x86_64 version of bdk-android throws a runtime error when used from an x86_64 machine (but not from an M1).

Native library (android-x86-64/libbdkffi.so) not found in resource path (.)

This is a known issue as per the links above.

notmandatory added a commit that referenced this issue Apr 13, 2023
@notmandatory
Merge #335: Use version 21 of the Android NDK in the CI test, build, …
0e6b472 
…and publish workflows

beb75dd Use version 21 of the Android NDK in the CI test, build, and publish workflows (thunderbiscuit)

Pull request description:

  This PR reverts an update to our Android CI workflows.

  For info on why this is needed, see issues #242 and #243.

ACKs for top commit:
  notmandatory:
    ACK beb75dd

Tree-SHA512: dfee0b1f335318b86fa490fa85e7ef5d7a032e01a78db64a186c5d75e9e77e8f0e2af58ee5407d4fe38a0aa3aabbc7b06b23189aef0dfaad1d246a354452870d
This was referenced Apr 17, 2023
Closed
Closed
@thunderbiscuit thunderbiscuit mentioned this issue Nov 10, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in BDK-Kotlin Roadmap Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thunderbiscuit thunderbiscuit

Labels
CI Continuous integration pipeline related language: kotlin platform: android
Projects
No open projects
BDK-Kotlin Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Rust compiler to 1.73.0 and update uniffi to 0.25.1 thunderbiscuit/bdk-ffi
2 participants
@notmandatory @thunderbiscuit