[Qt][WIP] allow possibility to add a comment to a WalletTx #5905

jonasschnelli · 2015-03-15T15:44:59Z

Try to sync rpc/qt wallets implementations.
Solves #2086.

    {
        "account" : "",
        "address" : "mm2STH7X3rbBVd73XaDrwdJHM69ukj31N8",
        "category" : "send",
        "amount" : -1.00000000,
        "vout" : 1,
        "fee" : -0.00000521,
        "confirmations" : 0,
        "txid" : "151e1e32090b765ebc30ebcc385bd79978081130b331972b94e142f3aeb85e10",
        "walletconflicts" : [
        ],
        "time" : 1426434053,
        "timereceived" : 1426434053,
        "comment" : "This is a test wtx comment."
    }

Diapolo · 2015-03-16T10:11:42Z

src/qt/walletmodeltransaction.cpp

@@ -65,3 +65,8 @@ CReserveKey *WalletModelTransaction::getPossibleKeyChange()
 {
    return keyChange;
 }
+
+void WalletModelTransaction::setComment(QString comment)


Can this be a const reference?

laanwj · 2015-03-16T10:15:46Z

Agree on the idea. Maybe we can make the comment editable too in the details view? As the information is purely local, there is no reason why it shouldn't be possible to add comments in retrospect.

jonasschnelli · 2015-03-16T10:27:05Z

@laanwj Yes. This is a good idea. Let me try to extend the editable comment to the transaction details window. What about adding a possibility to change the comment over RPC (without adding a new rpc call)?

luke-jr · 2015-03-16T13:39:55Z

How is this any different from the Label? Seems redundant.

jonasschnelli · 2015-03-16T17:02:27Z

@luke-jr comments already exists in RPC world and are per walletTx.
Labels are per address as far as I know.

jonasschnelli · 2015-03-18T13:08:44Z

@laanwj making the local comment editable within the TransactionDetailDialog looks after a big diff. It needs changes here and there and may be hard to review. It would also require changes within CWallet. IMO wtx are currently meant to be immutable. I would like to keep the PR as it is and address this "extension" in another PR.

luke-jr · 2015-03-18T13:19:03Z

@jonasschnelli Addresses are per walletTx generally as well (at least in proper use, which should be encouraged). RPC "comments" are basically just the deprecated accounting stuff which didn't have addresses associated.

jonasschnelli · 2015-03-18T13:25:58Z

@luke-jr "comments" are not directly related with "accounts". By now they where not deprecated. sendtoaddress uses them and i think having a possibility to give a transaction a comment makes sense.

luke-jr · 2015-03-18T13:36:07Z

Hm, interesting. Surprised that isn't using the label stuff. It would make sense to deprecate labels for comments, in that case, except that it's impossible to assign a comment to an incoming request right now. Labels work better in that regard. But having both is just confusing since they serve the same purpose...

laanwj · 2015-03-20T11:12:32Z

Looks like a lot of people are making the label-comment confusion, even in #2086.

Personally I'd say the distinction is the following:

label is a, usually short, name for the recipient or address
comment is arbitrary free text associated the the transaction. This can be anything from a description to e.g. current exchange rates for accounting/tax purposes

The annoying/user-surprising thing about these comments, though, is that they apply to a network-level transaction, so they would seem to be associated with multiple UI transactions if there are multiple outputs.

luke-jr · 2015-03-20T14:46:23Z

It also means you can't add comments to incoming transactions until after they're received (and confirm?). Maybe comment should be a text-area in the UI rather than a single line, and in the new wallet associated with an address so it has the same flexibility?

laanwj · 2015-03-20T15:20:02Z

Maybe comment should be a text-area in the UI rather than a single line

+1 I somehow assumed that'd already be the case.

jonasschnelli · 2015-03-26T13:15:28Z

Maybe comment should be a text-area in the UI rather than a single line

This PR will add a multiline text-area for adding comments to outgoing transactions.

[...] and in the new wallet associated with an address so it has the same flexibility?

I think adding comments to a wtx is something different to a address label. Lets say if i do ONE wtx to serval recipients it is nice then to give that ONE wtx a comment and not every receiving address.

But i'm also not completely sure what would be best for handling labels and comments.

Diapolo · 2015-03-26T14:46:48Z

src/qt/walletmodeltransaction.cpp

@@ -65,3 +65,8 @@ CReserveKey *WalletModelTransaction::getPossibleKeyChange()
 {
    return keyChange;
 }
+
+void WalletModelTransaction::setComment(const QString comment)


You could also use a pass-by-reference here ;)?
const QString& comment

jonasschnelli · 2015-04-02T20:14:13Z

rebased and fixed @Diapolo 's nit

jgarzik · 2015-09-15T18:10:50Z

ut ACK

jonasschnelli · 2015-09-15T20:31:03Z

Rebased.

It will slightly reduce the space in the already very packed sendcoinsdialog.
But i think it's useful.
I'm not sure if – long term speaking – the Addressbook has a reason to exists. The word "Adressbook" itself is connected to address reuse. If people using the Addressbook to label and track payments, then we should slowly remove (or rename and rewrite) the Addressbook and switch over to wallet comments.

maflcko · 2015-09-16T10:23:36Z

Looks good to merge.

Screenshot:

gmaxwell · 2015-11-22T22:57:13Z

utACK. But can we also add an RPC to set these?

jonasschnelli · 2015-11-24T11:55:45Z

@gmaxwell: Thanks for the review. Some test would be required, I agree. I'm also not fully happy with the UI look and feel. Consider the PR as WIP (changed title).

pstratem · 2015-12-08T21:42:26Z

lightly tested ACK 1dcdd42

sipa · 2016-05-20T16:19:41Z

Concept ACK

paveljanik · 2016-10-08T16:46:43Z

Concept ACK

RPC first please.

jonasschnelli · 2016-10-18T19:34:12Z

@paveljanik: It's already possible in RPC sendtoaddress \"bitcoinaddress\" amount ( \"comment\" \"comment-to\" subtractfeefromamount )

I don't think the current GUI UX makes sense...
Closing for now and maybe reopening after #7729

paveljanik · 2016-10-18T19:45:29Z

@jonasschnelli Hmm, it is not possible to use sendtoaddress RPC command to add comment to already received transaction from someone else.

jonasschnelli · 2016-10-18T19:48:54Z

@paveljanik: this PR only allows to set the comment during GUI tx creation (which is also a point that makes this PR currently not ready).

paveljanik · 2016-10-18T19:59:42Z

Ah, then yes :-)

sipa added the GUI label Mar 16, 2015

Diapolo reviewed Mar 16, 2015
View reviewed changes

jonasschnelli force-pushed the 2015/03/qt_tx_comment branch from 7db577d to 6b1360d Compare March 18, 2015 13:09

Diapolo reviewed Mar 26, 2015
View reviewed changes

jonasschnelli force-pushed the 2015/03/qt_tx_comment branch from 6b1360d to 16c0fc4 Compare April 2, 2015 20:13

[Qt] allow possibility to add a comment to a WalletTx

1dcdd42

jonasschnelli force-pushed the 2015/03/qt_tx_comment branch from 16c0fc4 to 1dcdd42 Compare September 15, 2015 20:15

jonasschnelli mentioned this pull request Nov 16, 2015

Bitcoin-Qt: Label use non-intuitive to newbies: appears to be per-transaction rather than per-address #1168

Closed

jonasschnelli changed the title ~~[Qt] allow possibility to add a comment to a WalletTx~~ [Qt][WIP] allow possibility to add a comment to a WalletTx Nov 24, 2015

jonasschnelli mentioned this pull request Jul 6, 2016

Make it possible to add a comment to a transaction #2086

Closed

jonasschnelli closed this Oct 18, 2016

jonasschnelli mentioned this pull request Aug 4, 2018

Add RPC to set transaction comment #12594

Closed

maflcko mentioned this pull request Feb 2, 2021

Setting a label on bitcoin-qt changes the label of all unlabeled transactions #21057

Closed

surak mentioned this pull request Feb 2, 2021

"Label" for receiving addresses, and its position in context menu is misleading bitcoin-core/gui#209

Closed

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Qt][WIP] allow possibility to add a comment to a WalletTx #5905

[Qt][WIP] allow possibility to add a comment to a WalletTx #5905

jonasschnelli commented Mar 15, 2015

Diapolo Mar 16, 2015

laanwj commented Mar 16, 2015

jonasschnelli commented Mar 16, 2015

luke-jr commented Mar 16, 2015

jonasschnelli commented Mar 16, 2015

jonasschnelli commented Mar 18, 2015

luke-jr commented Mar 18, 2015

jonasschnelli commented Mar 18, 2015

luke-jr commented Mar 18, 2015

laanwj commented Mar 20, 2015

luke-jr commented Mar 20, 2015

laanwj commented Mar 20, 2015

jonasschnelli commented Mar 26, 2015

Diapolo Mar 26, 2015

jonasschnelli commented Apr 2, 2015

jgarzik commented Sep 15, 2015

jonasschnelli commented Sep 15, 2015

maflcko commented Sep 16, 2015

gmaxwell commented Nov 22, 2015

jonasschnelli commented Nov 24, 2015

pstratem commented Dec 8, 2015

sipa commented May 20, 2016

paveljanik commented Oct 8, 2016

jonasschnelli commented Oct 18, 2016

paveljanik commented Oct 18, 2016 •

edited

Loading

jonasschnelli commented Oct 18, 2016

paveljanik commented Oct 18, 2016

[Qt][WIP] allow possibility to add a comment to a WalletTx #5905

[Qt][WIP] allow possibility to add a comment to a WalletTx #5905

Conversation

jonasschnelli commented Mar 15, 2015

Diapolo Mar 16, 2015

Choose a reason for hiding this comment

laanwj commented Mar 16, 2015

jonasschnelli commented Mar 16, 2015

luke-jr commented Mar 16, 2015

jonasschnelli commented Mar 16, 2015

jonasschnelli commented Mar 18, 2015

luke-jr commented Mar 18, 2015

jonasschnelli commented Mar 18, 2015

luke-jr commented Mar 18, 2015

laanwj commented Mar 20, 2015

luke-jr commented Mar 20, 2015

laanwj commented Mar 20, 2015

jonasschnelli commented Mar 26, 2015

Diapolo Mar 26, 2015

Choose a reason for hiding this comment

jonasschnelli commented Apr 2, 2015

jgarzik commented Sep 15, 2015

jonasschnelli commented Sep 15, 2015

maflcko commented Sep 16, 2015

gmaxwell commented Nov 22, 2015

jonasschnelli commented Nov 24, 2015

pstratem commented Dec 8, 2015

sipa commented May 20, 2016

paveljanik commented Oct 8, 2016

jonasschnelli commented Oct 18, 2016

paveljanik commented Oct 18, 2016 • edited Loading

jonasschnelli commented Oct 18, 2016

paveljanik commented Oct 18, 2016

paveljanik commented Oct 18, 2016 •

edited

Loading