test: add coverage to rpc_scantxoutset.py

[ismaelsadeeq]

Include a test that checks whether the first argument of scantxoutset RPC call "start" is required.
The rpc call should fail if the "start" argument is not provided.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	MarcoFalke
Concept ACK	kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[kevkevinpal]

utACK by visually looking at the code I can see 3 different options
status abort and start which requires 1 argument

but if it doesn't get any of the above options it calls JSONRPCError link below
Link to blockchain.cpp Line #2243

[ismaelsadeeq]

Thank you @kevkevinpal Yes if it gets an argument that is not status abort or start
blockchain.cpp#L2243 is called.

But
scantxoutsetaction argument is specified as
RPCArg::Optional::NO blockchain.cpp#L2062.
If there are no arguments scantxoutset won't be called at all.
It returns the entire method help string.

That is what 7e3d4f8 is checking for rpc_scantxoutset.py#L124
But with the abbreviation of the method help string
"scantxoutset \"action\" ( [scanobjects,...] )"

[kevkevinpal]

ok I see so this is a scenario where no command is entered. Should there also be a test for when something other than start abort or status is entered?

[ismaelsadeeq]

Yes can be something like
assert_raises_rpc_error(-8, "Invalid action 'word'", self.nodes[0].scantxoutset, "word")

[kevkevinpal]

Yes can be something like assert_raises_rpc_error(-8, "Invalid action 'word'", self.nodes[0].scantxoutset, "word")

opened PR for this #27453
let me know if you have any comments

[fanquake]

cc @theStack @MarcoFalke

[maflcko]

lgtm ACK 7e3d4f8