Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

English translation not used (correctly?) in English KDE #1127

Closed
luke-jr opened this issue Apr 20, 2012 · 7 comments
Closed

English translation not used (correctly?) in English KDE #1127

luke-jr opened this issue Apr 20, 2012 · 7 comments

Comments

@luke-jr
Copy link
Member

luke-jr commented Apr 20, 2012

I'm seeing the "~5 block(s) remaining" rather than "~5 blocks remaining"
@laanwj
Copy link
Member

laanwj commented Apr 20, 2012

What's your LOCALE / LANG?

My guess is that somehow it doesn't detect your language as english but as some unknown language.

@luke-jr
Copy link
Member Author

luke-jr commented Apr 20, 2012

LANG=en_GB.utf8
LC_COLLATE=C

@laanwj
Copy link
Member

laanwj commented Apr 20, 2012

I've tried setting those environment variables and it works fine.

I wonder what value does lang_territory take in bitcoin.cpp in your case?

@luke-jr
Copy link
Member Author

luke-jr commented Apr 20, 2012

lang_territory is "en_GB"

Also, shouldn't the en locale be used for unsupported locales anyway?

@laanwj
Copy link
Member

laanwj commented Apr 20, 2012

That may be a sane thing to do. But it's not the case right now.

Anyway, in the case of "en_GB" it tries "en", so this doesn't explain the problem.

@luke-jr
Copy link
Member Author

luke-jr commented Apr 20, 2012

Oddly, git master seems to work... bisecting now

@luke-jr
Copy link
Member Author

luke-jr commented Apr 20, 2012

Doh, it was fixed in:

commit 3fddc8e (HEAD, origin-pull/1089/head, laanwj/2012_04_translationupdate)
Author: Wladimir J. van der Laan laanwj@gmail.com
Date: Fri Apr 13 08:45:26 2012 +0200

Update translations for bitcoin core

- Move scripts/qt to share/qt, to clean up toplevel directories
- Update english ts file which is used to source messages for Transifex
- In extract_strings_qt.py use a glob *.h *.cpp, this is safe now that the Wx UI files are removed

@luke-jr luke-jr closed this as completed Apr 20, 2012
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this issue Dec 5, 2017
@UdjinM6
Fix exit codes (bitcoin#1127)
d2f1fd2 
* Fix exit codes:
- `--help`, `--version` etc should exit with `0` i.e. no error ("not enough args" case should still trigger an error)
- error reading config file should exit with error
- slightly refactor AppInitRPC/AppInitRawTx to return standard exit codes (EXIT_FAILURE/EXIT_SUCCESS) or CONTINUE_EXECUTION (-1)
- every main()/exit() should return/use one of EXIT_ codes instead of magic numbers
lateminer pushed a commit to lateminer/bitcoin that referenced this issue Jan 22, 2019
@gandrewstone
Merge pull request bitcoin#1127 from awemany/utf8-enc
8f8ca48 
Make sure that RPC tests work with locale LC_ALL=C
lateminer pushed a commit to lateminer/bitcoin that referenced this issue Dec 25, 2019
@random-zebra
Merge bitcoin#1127: [Deployment] Windows taskbar icon pixelated fix.
c7bc2e1 
1468a9e [Deployment] Windows taskbar icon pixelated. (furszy)

Pull request description:

  Windows taskbar icon pixelated (bitcoin#1108), new icon created.

  Thanks Rhubarbarian for the icon resource.

ACKs for top commit:
  Warrows:
    ACK 1468a9e
  Mrs-X:
    ACK PIVX-Project@1468a9e
  random-zebra:
    utACK 1468a9e and merging...

Tree-SHA512: dafd70492ff00647fd7f2c0866a83a79c5de80031f7907fecc45b4532b06e2d5bc5fe49271fcb67b34a670fae7ce192ad292d2a81d3cdf3215c1ae97ee3ff886
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laanwj @luke-jr