bip-325: correct placement of challenge #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @ajtowns. |
ajtowns
reviewed
Oct 6, 2020
bip-0325.mediawiki
Outdated
| @@ -60,8 +60,10 @@ The "to_sign" transaction is: | |||
| vin[0].prevout.hash = to_spend.txid | |||
| vin[0].prevout.n = 0 | |||
| vin[0].nSequence = 0 | |||
| vin[0].sigScript = [ signet_challenge first data push, if any ] | |||
| vin[0].scriptWitness = [ signet_challenge second data push, if any ] | |||
There was a problem hiding this comment.
These are from the signet solution, not the signet challenge, and there's only a single data push of the serialization of the scriptSig and and scriptWitness concatenated.
There was a problem hiding this comment.
Doh, I meant the signet solution.
There's a single push, of the 1-2 pushes of sigScript followed by optional scriptWitness, right? That's what I'm referring to.
There was a problem hiding this comment.
Gah, I meant the solution, not challenge.
ccbb7bf to
fd50eea
Compare
maflcko
reviewed
Oct 6, 2020
bip-0325.mediawiki
Outdated
| @@ -60,8 +60,10 @@ The "to_sign" transaction is: | |||
| vin[0].prevout.hash = to_spend.txid | |||
| vin[0].prevout.n = 0 | |||
| vin[0].nSequence = 0 | |||
| vin[0].sigScript = [ signet_solution first data push, if any ] | |||
| vin[0].scriptWitness = [ signet_solution second data push, if any ] | |||
There was a problem hiding this comment.
Suggested change
| vin[0].scriptWitness = [ signet_solution second data push, if any ] | |
| vin[0].scriptWitness = [ signet_solution scriptWitness (y bytes), if any ] |
Maybe refer to it with the length to avoid the "data push" confusion?
fd50eea to
bb989a6
Compare
|
Looks good to me |
|
Ping @luke-jr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1003 (comment) (where I adopt the approach here), it is pointed out that the message signature going into the scriptPubKey of the spending transaction is weird.
It should go into the scriptSig and/or scriptWitness, and the scriptPubKey for the spending tx is OP_RETURN.