BIP155: Mention SHA3-256 explicitly #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Sep 27, 2020
bip-0155.mediawiki
Outdated
| @@ -166,10 +166,11 @@ onion_address = base32(PUBKEY | CHECKSUM | VERSION) + ".onion" | |||
| CHECKSUM = H(".onion checksum" | PUBKEY | VERSION)[:2] | |||
|
|
|||
| where: | |||
| - PUBKEY is the 32 bytes ed25519 master pubkey of the hidden service. | |||
| - PUBKEY is the 32 bytes ed25519 master pubkey of the hidden service | |||
| - VERSION is an one byte version field (default value '\x03') | |||
There was a problem hiding this comment.
While here, if you are inclined to, could s/an one/a one/ and remove the EOL whitespace at line 155: The new message introduces a separate network ID for <code>TORV2</code>.
a5a6a50 to
6ef71b3
Compare
|
ACK 6ef71b3 Duplicating the Tor spec into this BIP does not seem very useful to me, but, ok, since we already have some of it, why not clarify what is |
|
ACK 6ef71b3
The reason part of the Tor spec is rehashed here is because the specific
internals of the address format are relevant to the encoding.
…On Mon, Oct 5, 2020, 19:24 Luke Dashjr ***@***.***> wrote:
Assigned #1002 <#1002> to @laanwj
<https://github.com/laanwj>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1002 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA65NV7XYQS7FYPJRDG5HDSJH6LDANCNFSM4R3OCQFQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems better to clarify that
CHECKSUMin Tor onion v3 address uses SHA3-256 hash function.