Skip to content

Commit

Permalink
BIP155: change "time" to fixed 32 bit unsigned
Browse files Browse the repository at this point in the history
32 bit unsigned can represent time up to year 2106
(32 bit signed is limited to just 2038).

So, we don't need to have "time" encoded as variable integer which would
take 5 bytes instead of 4.
  • Loading branch information
vasild committed Aug 13, 2020
1 parent cb071df commit 2c7630e
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions bip-0155.mediawiki
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ The <code>addrv2</code> message is defined as a message where <code>pchCommand =
It is serialized in the standard encoding for P2P messages.
Its format is similar to the current <code>addr</code> message format
<ref>[https://bitcoin.org/en/developer-reference#addr Bitcoin Developer Reference: addr message]</ref>, with the difference that the
fixed 16-byte IP address is replaced by a network ID and a variable-length address, and the time and services format has been changed to VARINT.
fixed 16-byte IP address is replaced by a network ID and a variable-length address, and the services format has been changed to VARINT.

This means that the message contains a serialized <code>std::vector</code> of the following structure:

Expand All @@ -55,9 +55,9 @@ This means that the message contains a serialized <code>std::vector</code> of th
!Name
!Description
|-
| <code>VARINT</code> (unsigned)
| <code>uint32_t</code>
| <code>time</code>
| Time that this node was last seen as connected to the network. A time in Unix epoch time format, up to 64 bits wide.
| Time that this node was last seen as connected to the network. A time in Unix epoch time format.
|-
| <code>VARINT</code> (unsigned)
| <code>services</code>
Expand Down Expand Up @@ -144,8 +144,6 @@ The reference implementation is available at (to be done)

- Jonas Schnelli: change <code>services</code> field to VARINT, to make the message more compact in the likely case instead of always using 8 bytes.

- Luke-Jr: change <code>time</code> field to VARINT, for post-2038 compatibility.

- Gregory Maxwell: various suggestions regarding extensibility

==Appendix A: Tor v2 address encoding==
Expand Down

0 comments on commit 2c7630e

Please sign in to comment.