Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in more self-documenting code.
|
Meh. I've never been a fan of replacing simple immediate (near-)single use immutable values with construction-opaque macros. But doing this here makes the code more consistent, so I will defer to the judgement that went into using EVEN and ODD in the surrounding code previously and ACK. I reserve the right to whine about the conversion of other simple constants elsewhere. :P |
gmaxwell
added a commit
that referenced
this pull request
Feb 21, 2019
…y_parse d3cb1f9 Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse (Ben Woosley) Pull request description: This results in more self-documenting code. Constants defined here: https://github.com/bitcoin-core/secp256k1/blob/1e6f1f5ad5e7f1e3ef79313ec02023902bf8175c/include/secp256k1.h#L175-L180 Tree-SHA512: 2026103c487a5ebdea9a2f5ec2be96d74e38d5b2269b4df11e354bb54aba2925b47c3185f530205019840b00fc3501121acfa5234faf1d095d71777826414f69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in more self-documenting code.
Constants defined here:
secp256k1/include/secp256k1.h
Lines 175 to 180 in 1e6f1f5