secp256k1_fe_sqrt: Verify that the arguments don't alias. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76be8c3 to
bf8b86c
Compare
|
Please change to |
|
I think your requested amendment is a good idea. However, I do not currently have the energy to shepherd this PR. Maintainers have permission to edit this branch, otherwise you can fork this PR and continue with a new PR. |
gmaxwell
added a commit
that referenced
this pull request
Feb 21, 2019
bf8b86c secp256k1_fe_sqrt: Verify that the arguments don't alias. (Russell O'Connor) Pull request description: Tree-SHA512: 4e9128625817be83a1259e7dbdb82c4be8ee0174af7d5e76eeac3245d23d6bf01378d9697dcb870eb61577afd7c0556cb3c6633e3b27504add14c10b18f7c607
gmaxwell
added a commit
that referenced
this pull request
Feb 24, 2019
… aliasing. b76e45d Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing. (Gregory Maxwell) Pull request description: Bench_internal was previously incorrect but wasn't detected by -DVERIFY until PR #551. Tree-SHA512: 5ecb9e3ba63ddf28cde4012154dbb1dda9b7178016d970dba58a4af20c31aa1ec3458ba2623541233fb16fceff7b3053054d6eee0229d0bfb6281d1a10554e9f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.