Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm ASM builds are broken #931

Closed
gmaxwell opened this issue May 2, 2021 · 1 comment
Closed

Arm ASM builds are broken #931

gmaxwell opened this issue May 2, 2021 · 1 comment

Comments

@gmaxwell
Copy link
Contributor

gmaxwell commented May 2, 2021

Gen_context tries to use ASM but doesn't get linked against it:

gcc -O2 -fvisibility=hidden -std=c89 -pedantic -Wall -Wextra -Wcast-align -Wnested-externs -Wshadow -Wstrict-prototypes -Wundef -Wno-unused-function -Wno-long-long -Wno-overlength-strings -W -g  gen_context.o -o gen_context
gen_context.o: In function `secp256k1_fe_mul':
/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1078: undefined reference to `secp256k1_fe_mul_inner'
gen_context.o: In function `secp256k1_fe_sqr':
/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1091: undefined reference to `secp256k1_fe_sqr_inner'
/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1091: undefined reference to `secp256k1_fe_sqr_inner'
/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1091: undefined reference to `secp256k1_fe_sqr_inner'
/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1091: undefined reference to `secp256k1_fe_sqr_inner'
...

Reverting a3aa262 fixes it.

@sipa
Copy link
Contributor

sipa commented May 2, 2021

Related: going to work on adding ARM32/ARM64 CI in #930 so that these things don't silently break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants