Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URI/file handling message #251

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 17, 2021

This PR:

  • fixes missing spaces after full stops
  • makes the translation context much bigger

The latter is the main motivation for this PR, as I became a translator 🐅

Screenshots:

DeepinScreenshot_select-area_20210317211750

  • this PR:

Screenshot from 2021-03-17 21-13-36

This change:
- fixes missing spaces after full stops
- makes translation context bigger
@hebasto hebasto added the Doc label Mar 17, 2021
@hebasto hebasto changed the title qt: Improve URI/file handling message Improve URI/file handling message Mar 17, 2021
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ef3e1d7

Looking on transifex. I See that on master all of these strings would be broken up into seperate translations:

Screen Shot 2021-03-24 at 11 39 37 AM

This would unify these strings under one translation. This added context should be a benefit to translators

@maflcko maflcko merged commit ea3c9a9 into bitcoin-core:master Mar 29, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 29, 2021
ef3e1d7 qt: Improve URI/file handling message (Hennadii Stepanov)

Pull request description:

  This PR:
  - fixes missing spaces after full stops
  - makes the translation context much bigger

  The latter is the main motivation for this PR, as I became a translator 🐅

  Screenshots:
  - master (a9d1b40)

  ![DeepinScreenshot_select-area_20210317211750](https://user-images.githubusercontent.com/32963518/111527570-bd776880-8768-11eb-9035-96bb08067e74.png)

  - this PR:

  ![Screenshot from 2021-03-17 21-13-36](https://user-images.githubusercontent.com/32963518/111527727-e7308f80-8768-11eb-95c7-e8b802bfed5f.png)

ACKs for top commit:
  jarolrod:
    ACK ef3e1d7

Tree-SHA512: 8fbd1e3731b75866356fae201b3129126001600ca0197e83c05825e8c5bbbcf0132d6a6b808d7a5cbfbdde75ed1865ecbb651c30017570abd7c5803eff2b9306
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants