Add "Last Block" and "Last Tx" rows to peer details area

[jonatack]

• add RPCConsole::TimeDurationField helper to replace repeated code and call system time only once in RPCConsole::updateDetailWidget
• add "Last Tx" (CNodeStats::nLastTXTime) field to peer details
• add "Last Block" (CNodeStats::nLastBlockTime) field to peer details

[jonatack]

Screenshots 🍰

[jarolrod]

ACK c275898

Small nits, maybe the extra explanation is not needed. Feel free to ignore.

[jonatack]

Thanks for having a look, @jarolrod! Much appreciated.

The docs echo the ones I added in the -netinfo help and are a compact version of those I added to src/net.h:

Time since last novel transaction received from the peer and accepted into our mempool, in minutes
Time since last novel block passing initial validity checks received from the peer, in minutes

    /** UNIX epoch time of the last block received from this peer that we had
     * not yet seen (e.g. not already received from another peer), that passed
     * preliminary validity checks and was saved to disk, even if we don't
     * connect the block or it eventually fails connection. Used as an inbound
     * peer eviction criterium in CConnman::AttemptToEvictConnection. */

    /** UNIX epoch time of the last transaction received from this peer that we
     * had not yet seen (e.g. not already received from another peer) and that
     * was accepted into our mempool. Used as an inbound peer eviction criterium
     * in CConnman::AttemptToEvictConnection. */

which I think are a bit more useful to users than the equivalent ones I added in the getpeerinfo rpc help (I've been adding these docs everywhere, hehe). For example, if we receive a novel block that does not pass initial validity checks, or a novel transaction that isn't accepted into our mempool, it won't appear--and the simplified docs would be incorrect. A user might wonder why, but the answers are difficult for casual users to glean from reading the code, and while writing the docs it took some review discussion with others to get this info cleared up. So it seems worth documenting when we have the space to do so.

[jarolrod]

@jonatack thanks for the context, looks good to me then 👍

[hebasto]

Concept ACK. Will review in the morning :)

[jonatack]

Updated per git diff c275898 a5b349 to not use the helper for peerConnTime (and inverted the order of the helper arguments).

[hebasto]

ACK a5b349a, tested on Linux Mint 20.1 (Qt 5.12.8):

piconit: while here why not to fix indentation from #179:

--- a/src/qt/forms/debugwindow.ui
+++ b/src/qt/forms/debugwindow.ui
@@ -1079,7 +1079,7 @@
                <item row="1" column="0">
                 <widget class="QLabel" name="peerConnectionTypeLabel">
                  <property name="toolTip">
-                   <string>The direction and type of peer connection: %1</string>
+                  <string>The direction and type of peer connection: %1</string>
                  </property>
                  <property name="text">
                   <string>Direction/Type</string>

[jonatack]

Thanks @hebasto, done.

[hebasto]

re-ACK 70d3c5d

Thank you @jonatack !

[jarolrod]

re-ack 70d3c5d