add font awesome free font to .fab class to allow non-brands icons in socials links section. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitbrain
pushed a commit
that referenced
this pull request
Jan 13, 2023
odintheprotector
pushed a commit
to odintheprotector/odintheprotector.github.io
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently only the font awesome brands icons work when configuring the socials section in the _config.yml. This will make it possible to also use the standard font awesome icons.
The Font Awesome 5 Free font is already imported in https://github.com/bitbrain/jekyll-dash/blob/main/_sass/dash.scss. Also it is being used for the Tags icon.
Addressed issues
Screenshots