Add type for ObjectManager helper for tests #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shochdoerfer
commented
Nov 28, 2020
| ): Type { | ||
| $className = $scope->getType($methodCall->args[0]->value)->getValue(); | ||
| if (!is_subclass_of($className, \Magento\Framework\Data\Collection::class)) { | ||
| new \PHPStan\Type\MixedType(); |
There was a problem hiding this comment.
@ondrejmirtes would it be possible here to return "an error" when a wrong implementation is passed? I tried to throw a ShouldNotHappenException but that killed phpstan ;(
| MethodCall $methodCall, | ||
| Scope $scope | ||
| ): Type { | ||
| return TypeCombinator::addNull(new ArrayType(new StringType(), new MixedType())); |
There was a problem hiding this comment.
@ondrejmirtes would it be possible here to define the keys and values of the array? Magento would filter out the array that is passed the method and return only valid dependencies. Would be cool to mimic this there if phpstan could also check further on the contents of the array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.