Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve "Auto-remove" ("Remove & Retention") GUI and its documentation #2000

Merged
merged 56 commits into from
Feb 2, 2025

Conversation

buhtz
Copy link
Member

@buhtz buhtz commented Jan 9, 2025

  • The terms "Auto-Remove" and "Smart-Remove" are renamed into "Remove & Retention" and "Retention Policy".
  • The way this feature works is now more clearly illustrated in the GUI. Additionally, the user manual now contains a corresponding section, including examples.
  • Labels and tooltips in the GUI are modified.
    image

The behavior itself was not changed. Also no code refactoring was done to reduce the risk of introducing bugs.

Now after it is more clear how that feature works, the next step is to refactor the productive code, to improve unit tests. After that the feature is free to get revised. See meta issue #1945 for details and discussions.

Close #1976

@buhtz buhtz marked this pull request as draft January 9, 2025 16:50
@buhtz buhtz self-assigned this Jan 9, 2025
@buhtz buhtz added this to the 1.6.0 (upcoming release) milestone Jan 9, 2025
@buhtz buhtz mentioned this pull request Jan 9, 2025
@buhtz
Copy link
Member Author

buhtz commented Jan 29, 2025

@buhtz buhtz added PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team. PR: Merge after creative-break Merge after creative-break (min. 1 week) labels Jan 31, 2025
@buhtz buhtz marked this pull request as ready for review January 31, 2025 21:34
@buhtz
Copy link
Member Author

buhtz commented Jan 31, 2025

Boa! What a f*** boring task. 🤣

@buhtz buhtz merged commit 97d4dc6 into bit-team:dev Feb 2, 2025
@buhtz buhtz deleted the fix/1976retention branch February 2, 2025 12:07
buhtz added a commit that referenced this pull request Feb 13, 2025
# Summary
This is a release candidate. Please report if you use it even if there are no new problems.

This version is set to be released with Debian 13 (Trixie) this early summer and will remain available for the long lifetime of that Debian version.
EncFS, used for encrypted profiles, has been marked as deprecated and is  schedule for removal in 2026. The Smart & Auto remove GUI has been reorganized and renamed into "Remove & Retention", with improvements to the user manual section. Its behavior remains unchange. An offset minute can now be configured for hourly schedule options. Some config file fields have been moved to a newly introduced state file. License and copyright information is now provided in machine-readable SPDX format, following the REUSE standard.

# Contributors
This version received extensive support from contributors (in alphabetical order):

 - @bremnere
 - David Gibbs @fallingrock
 - graysky @graysky2
 - Samuel More @mooresamuel
 - Iván Rodríguez @ivanrdgz03
 - Peter Sevens @sevens
 - David Wales @daviewales
 - Dylan Wilson @dylan-wilson-usq
 - Also not to be forgotten are the many people who supported the project by testing it, providing feedback, reporting issues, and analyzing problems.

# Known major issues open
- qt_probing.py may hang with high CPU usage when running Back In Time as root via cron (#1592)
- File permissions handling and therefore possible non-differential backups (#988 & #994)

# Changelog
* Changed: More clear and intense warning about EncFS deprecation and removal (#1904)
* Changed: Updated desktop entry files
* Changed: Move several values from config file into new introduce state file ($XDG_STATE_HOME/backintime.json)
* Changed: Completed license information to conform the REUSE.software and SPDX standards.
* Breaking Change: Auto-remove rules "Free inodes" and "Free space" disabled by default (#1976)
* Fix!: Smart-remove rule "Keep one snapshots per week or the last week" use calendar weeks
* Fix: The width of the fourth column in files view is now saved
* Fix: Snapshot compare copy symlink as symlink (#1902) (Peter Sevens @sevens)
* Fix: Crash when comparing a snapshot with a symlink pointing to a nonexistent target (Peter Sevens @sevens)
* Fix: Crash (KeyError) opening language setup dialog with unknown locale/language
* Feature: Open user manual (local if available otherwise online) via Help menu
* Feature: Toolbar context menu to display the buttons in different combinations with icons and text (#1105, #2002) (Samuel Moore @s4moore)
* Feature: Add offset minutes to hourly schedules (David Gibbs @fallingrock)
* Doc: Remove & Retention (formally known as Auto-/Smart-Remove) with improved GUI and user manual section (#2000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Merge after creative-break Merge after creative-break (min. 1 week) PR: Waiting for review PR won't be merged until review and approval from a member of the maintenance team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve appearance of Auto-remove GUI and docu
1 participant