Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: PyFakeFS minimal version 5.7 #1916

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

buhtz
Copy link
Member

@buhtz buhtz commented Oct 25, 2024

Minimal PyFakeFS version should be 5.6.

Until #1575 is implemented, as a workaround, a unit test does check this dependency if Python 3.12 or newer is used.

Thank you to Fedora maintainer @hannes101 bringing this up. Also to PyFakeFS maintainer @mrbean-bremen, "mock" maintainer @xsuchy and the python mailing list folks supporting the diagnostics.

Related to #1911

@buhtz buhtz added the PR: Merge after creative-break Merge after creative-break (min. 1 week) label Oct 25, 2024
@buhtz buhtz added this to the 1.5.3 (Upcoming release) milestone Oct 25, 2024
@buhtz buhtz self-assigned this Oct 25, 2024
@mrbean-bremen
Copy link

Just to clarify (already mentioned in the other issue): minimal version with Python 3.13 support is 5.7, not 5.6.
Python 3.12 support had been introduced in pyfakefs 5.3.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@buhtz buhtz changed the title build: PyFakeFS minimal version 5.6 build: PyFakeFS minimal version 5.7 Oct 27, 2024
@buhtz buhtz merged commit af0d1e0 into bit-team:dev Oct 30, 2024
1 check failed
@buhtz buhtz deleted the fix/1911shutilfedora branch October 30, 2024 11:09
@buhtz buhtz removed the PR: Merge after creative-break Merge after creative-break (min. 1 week) label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants