Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rearrange menu bar in main window #1487

Merged
merged 6 commits into from
Aug 6, 2023
Merged

feat: Rearrange menu bar in main window #1487

merged 6 commits into from
Aug 6, 2023

Conversation

buhtz
Copy link
Member

@buhtz buhtz commented Jul 26, 2023

Rearrange the menu bar in main window and its entries. Some labels and tooltips are modified.

I would say the entry for a Language Selection and maybe for Diagnostics can be handled in a separate PR.

Different from our discussion in #1482 I modified the order of the entries in the sub menus a bit. It is just a proposal and easy to modify.
Peek 2023-07-26 11-38

Close #1482

@buhtz buhtz added Discussion decision or consensus needed Cosmetics appearance, icons, themes labels Jul 26, 2023
@aryoda
Copy link
Contributor

aryoda commented Jul 26, 2023

All good!

Perhaps the shortcut for "Manage profiles" could be changed now (Ctrl + Shift + , is clumsy and neccessary because Ctrl + Shift + S was already used for "Take snapshots with checksum").

I think Ctrl + Shift + M (or P) could still be unused and more intuitive now...

BTW: Don't forget the changelog entry (could be done later when the GUI refactoring is change-stable)

@buhtz
Copy link
Member Author

buhtz commented Jul 26, 2023

BTW: Don't forget the changelog entry (could be done later when the GUI refactoring is change-stable)

Always... 🍌 I also added some "lost" changelog entries from previous PRs.

btw: Do you know about https://common-changelog.org/ as a standard how to write a changelog and its entries? I'm not experienced with it but try it in one of my own one-person-projects.

CHANGES Outdated Show resolved Hide resolved
@aryoda
Copy link
Contributor

aryoda commented Jul 26, 2023

btw: Do you know about https://common-changelog.org/ as a standard how to write a changelog and its entries?

I can't remember having read this one and I am little bit in-consequent here ("as it fits")

What I always hate is the lurking merge conflict in the changelog file if multiple devs work in different feature branches and I have already seen a fancy script in a project where the changelog entry per feature is contained in a separate folder and merge into the changelog when the feature is merged into the dev branch (all this to avoid merge conflicts)

@buhtz
Copy link
Member Author

buhtz commented Jul 26, 2023

I can't remember having read this one and I am little bit in-consequent here ("as it fits")

I'm also in-consequent. That's why I need a standard because I can't do it by my own. 😃

I have already seen a fancy script in a project where the changelog entry per feature is contained in a separate folder and merge into the changelog when the feature is merged into the dev branch (all this to avoid merge conflicts)

Yes, I've seen things like this, too. Hard to track for external contributors. Make sense in projects with more complex branching models then ours. We don't collect multiple features in separate public branches. We merge into "dev" all the time.

@@ -0,0 +1,2 @@
Don't forget the changelog entry! ;)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@aryoda
Copy link
Contributor

aryoda commented Aug 4, 2023

@buhtz Do you want to merge this, it looks fine!?

@aryoda aryoda merged commit a2557fe into bit-team:dev Aug 6, 2023
@buhtz buhtz deleted the feat/1482mainmenu branch August 6, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmetics appearance, icons, themes Discussion decision or consensus needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: re-arrange the menubar and its entries
2 participants