chore: remove need for extract_alerts.sh #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
biswassri
reviewed
Nov 15, 2024
| @@ -62,6 +62,3 @@ local.mk | |||
|
|
|||
| # Ignore temporary files created by the Makefile | |||
| *.mktmp.* | |||
|
|
|||
| #Ignore temporary alert yaml files created by the Makefile | |||
| *_alerts.yaml | |||
There was a problem hiding this comment.
@grdryn This I think is needed. Not only for these changes but so that anyone running prometheus-alert tests locally doesn't push these files by mistake.
There was a problem hiding this comment.
Ahh, I see you've added a separate .gitignore. But I'm not sure if there is a benefit of having a separate file for this.
2d87196 to
b4195fd
Compare
Make excels at tracking generated output files from specified input files (it might be the only thing it's good at). By having a convention of naming the generated rule files and their corresponding unit test files based on the file names in the ConfigMap, then we don't need a separate script to track the difference in what the files are called inside and outside the ConfigMap, which would need to be updated each time a new unit test file is added. With this change, as long as you name your unit test file in the appropriate way, and there's a corresponding entry in the ConfigMap, then the rule file should get extracted in the expected way.
b4195fd to
e8509c9
Compare
biswassri
pushed a commit
that referenced
this pull request
Nov 20, 2024
Current implementation incorrectly calls removal of a header which is manifested in ingress gateway proxy logs: ``` envoy lua external/envoy/source/extensions/filters/http/lua/lua_filter.cc:930 script log: [string "function envoy_on_request(request_handle)..."]:10: bad argument #1 to 'remove' (N5Envoy10Extensions11HttpFilters3Lua16HeaderMapWrapperE expected, got string` ``` This fixes the Lua syntax and marks Service Mesh Features related to KServe setup as `Managed()`. This ensures that updating the existing filters will happen on operator upgrade or next reconcile.
biswassri
pushed a commit
that referenced
this pull request
Nov 20, 2024
…ting (#1…" (red-hat-data-services#1122) This reverts commit d2f656a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make excels at tracking generated output files from specified input files (it might be the only thing it's good at).
By having a convention of naming the generated rule files and their corresponding unit test files based on the file names in the ConfigMap, then we don't need a separate script to track the difference in what the files are called inside and outside the ConfigMap, which would need to be updated each time a new unit test file is added. With this change, as long as you name your unit test file in the appropriate way, and there's a corresponding entry in the ConfigMap, then the rule file should get extracted in the expected way.
Description
How Has This Been Tested?
make test-alertsmake test-alertsagainmake -B test-alerts-BScreenshot or short clip
Merge criteria