Increase maxItems at requesting trade statistic items #7070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3000 items are about 180.325 kB. For nodes not being online for longer the repeated requests consumes quite some time. With 15k we can expect a 1 MB payload which is still acceptable. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
HenrikJannsen
added a commit
to HenrikJannsen/bisq
that referenced
this pull request
Apr 1, 2024
bisq-network#7069 and bisq-network#7070 as well as more recent resource data Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase maxItems from 3000 to 15000. 3000 items are about 180.325 kB.
For nodes not being online for longer the repeated requests consumes quite some time. With 15k we can expect a 1 MB payload which is still acceptable.
The past 6 months had about 18 000 trade statistic items.