Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to confirm before shutting down. #6435

Merged
merged 1 commit into from Dec 5, 2022
Merged

Prompt to confirm before shutting down. #6435

merged 1 commit into from Dec 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2022

Implements request from @pazza83 and #6427. Prevents accidental shutdown.

image

There are other checks which may cause an alternate prompt at shutdown:

  • Open offers
  • Trades which have not finished initializing
  • Dispute messages still waiting for an ack

At shutdown either one or the other will be shown, as long has user has not opted to bypass it.

image

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.9.7 milestone Dec 5, 2022
@ripcurlx ripcurlx merged commit 5dc006e into bisq-network:master Dec 5, 2022
@ghost ghost mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant